Mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
Date Mon, 21 Dec 2015 13:56:46 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066465#comment-15066465
] 

Mark Miller edited comment on SOLR-7339 at 12/21/15 1:56 PM:
-------------------------------------------------------------

bq. I think we should add that anyway even though it doesn't help fix these failures.

Let's open a separate issue for that. Internal HttpClient usage should be getting an instance
setup with the Retry policy that we want. I'm a little skeptical that we just want to hard
code it as off in the HttpSolrClient constructor, but perhaps there is something to dig into
there.

This upgrade is a bit scary at the moment. I see in one of the repeatable connection reset
issues, hard coding the Locale to English for the test makes it pass. Other issues don't seem
to relate to the Locale. Unless we can get to the bottom of this quickly, we may want to pull
this back and get a handle a better handle on the problems before putting it in.


was (Author: markrmiller@gmail.com):
bq. I think we should add that anyway even though it doesn't help fix these failures.

Let's open a separate issue for that. Internal HttpClient usage should get getting an instance
setup with the Retry policy that we want. I'm a little skeptical that we just want to hard
code it as off in the HttpSolrClient constructor, but perhaps there is something to dig into
there.

This upgrade is a bit scary at the moment. I see in one of the repeatable connection reset
issues, hard coding the Locale to English for the test makes it pass. Other issues don't seem
to relate to the Locale. Unless we can get to the bottom of this quickly, we may want to pull
this back and get a handle a better handle on the problems before putting it in.

> Upgrade Jetty from 9.2 to 9.3
> -----------------------------
>
>                 Key: SOLR-7339
>                 URL: https://issues.apache.org/jira/browse/SOLR-7339
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Gregg Donovan
>            Assignee: Shalin Shekhar Mangar
>             Fix For: Trunk
>
>         Attachments: SOLR-7339.patch, SOLR-7339.patch, SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor SPDY was shown
in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699] and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading Jetty. The
server configuration would need to change and a new HTTP client ([Jetty's own client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
[Square's OkHttp|http://square.github.io/okhttp/], [etc.|https://github.com/http2/http2-spec/wiki/Implementations])
would need to be selected and wired up. Perhaps this is worthy of a branch?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message