Mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anshum Gupta (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-8330) Restrict logger visibility throughout the codebase to private so that only the file that declares it can use it
Date Wed, 02 Dec 2015 09:06:11 GMT

     [ https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Anshum Gupta updated SOLR-8330:
-------------------------------
    Attachment: SOLR-8330.patch

Patch with a few more fixes that I came across while running ant clean, test, validate, and
precommit. The tests pass and all looks good. I'll commit this now.

Might have to deal with branch_5x merge next.

> Restrict logger visibility throughout the codebase to private so that only the file that
declares it can use it
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8330
>                 URL: https://issues.apache.org/jira/browse/SOLR-8330
>             Project: Solr
>          Issue Type: Sub-task
>    Affects Versions: Trunk
>            Reporter: Jason Gerlowski
>            Assignee: Anshum Gupta
>              Labels: logging
>             Fix For: Trunk
>
>         Attachments: SOLR-8330-combined.patch, SOLR-8330-detector.patch, SOLR-8330-detector.patch,
SOLR-8330.patch, SOLR-8330.patch, SOLR-8330.patch, SOLR-8330.patch, SOLR-8330.patch, SOLR-8330.patch,
SOLR-8330.patch
>
>
> As Mike Drob pointed out in Solr-8324, many loggers in Solr are unintentionally shared
between classes.  Many instances of this are caused by overzealous copy-paste.  This can make
debugging tougher, as messages appear to come from an incorrect location.
> As discussed in the comments on SOLR-8324, there also might be legitimate reasons for
sharing loggers between classes.  Where any ambiguity exists, these instances shouldn't be
touched.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message